Fix broken example tester workflow on draft-v8, and make tools runnable out of the box #1336
Conversation
|
It's possible that removing the MSBuildLocator call will cause the example tester task (not triggered here) to fail with one example changing its expected warnings. I'd like to add to the GitHub Actions filter for this PR to cause the tester to run when the tester code is changed. |
|
Sure enough, it's the removal of MSBuildLocator that causes the AnonymousFunctionsConv1 example to start producing only a single CS1661 error instead in place of two of the CS1661 errors that are being expected for that example. I'll try to collect compiler versions before and after and see what's up. |
jnm2
force-pushed
the
jnm2/tools
branch
3 times, most recently
from
5e6bf1a to
0af7c14
Compare
|
The compiler version is the same both before and after the change to stop using MSBuildLocator: It also turns out that this failure is unrelated to any of my PRs; the |
|
I bisected and found the cause of the failure at #1334 (review). I'll resolve both issues in this PR: the lack of workflow trigger so that the workflow did not run for that PR, and the failure itself. |
jnm2
changed the title
jnm2
changed the title
|
The failure was due to an intentional change in the Roslyn compiler v4.14, discussed at https://github.com/dotnet/roslyn/pull/75400/files#r1866802220. It doesn't make any difference for the purposes of the code example in the standard. I updated the expected diagnostics. |
…tion where there is also a CS1678 error (https://github.com/dotnet/roslyn/pull/75400/files#r1866802220)
There was a problem hiding this comment.
LGTM, but would be good to get @BillWagner to check as well.
There was a problem hiding this comment.
This LGTM as well. Thanks a lot @jnm2 This is really helpful.
Let's 
|
Some of the new path filters may need to be reverted on the workflows which are referenced by required checks: #1342 |
Fixes the following issues:
MSBuildLocator isn't needed (MSBuildWorkspace methods can't be called in the same method body as MSBuildLocator.RegisterInstance roslyn#78478 (comment)) and it is failing on my machine where I have only VS Preview installed. I believe MSBuildLocator by default doesn't see preview installations.
Add launch settings to the tools so that they are runnable immediately after cloning the repo by pressing F5 in Visual Studio. The launch settings contain the same arguments that are used for the workflow runs.
Fix the broken example tester workflow. Update DocumentFormat.OpenXml and 6 other dependencies #1334 (review) caused it to start failing for the AnonymousFunctionsConv1 example because it pulled in Roslyn v4.14, which no longer reports a CS1661 diagnostic at the same location as a CS1678 error. (Discussed at https://github.com/dotnet/roslyn/pull/75400/files#r1866802220.) The workflow did not run for that PR, so this was not discovered until unrelated PRs started coming through.
Add more paths to the example tester workflow trigger to catch issues like the above next time.
Also, this PR adds path filters for the other PR-triggered workflows so that they only run when files change which can currently affect them.
@BillWagner You had gitignored the launch profiles; what do you think about reversing this?