Remove assumptions about corresponding parameters #1350
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The corresponding parameter for a method argument with index i isn't necessarily i. An alternative approach would be to effectively consider type inferrence from the perspective of a normalized argument list. Fixes dotnet#981
jskeet
commented
Jun 14, 2025
jnm2
approved these changes
Jun 14, 2025
BillWagner
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
This also LGTM @jskeet
I made one suggestion to make sure I understand your comment.
Co-authored-by: Bill Wagner <[email protected]>
|
It looks like the text here has changed enough that it's possibly better to create a new PR. Will do so and get @BillWagner to review. |
jskeet
added a commit
to jskeet/csharpstandard
that referenced
this pull request
Sep 4, 2025
This replaces dotnet#1350. It's simpler due to dotnet#1359 centralizing the tie between an argument and the corresponding parameter's type. Fixes dotnet#981
jskeet
added a commit
to jskeet/csharpstandard
that referenced
this pull request
Sep 4, 2025
This replaces dotnet#1350. It's simpler due to dotnet#1359 centralizing the tie between an argument and the corresponding parameter's type. Fixes dotnet#981
|
Closing in favor of #1407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding parameter for a method argument with index i isn't necessarily i.
An alternative approach would be to effectively consider type inferrence from the perspective of a normalized argument list.
Fixes #981