Skip to content

Conversation

AndriySvyryd
Copy link
Member

Part of #31237

@AndriySvyryd AndriySvyryd requested a review from a team as a code owner April 5, 2025 01:36
@AndriySvyryd AndriySvyryd requested review from Copilot and removed request for a team April 5, 2025 01:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 37 out of 39 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • src/EFCore/Properties/CoreStrings.Designer.cs: Language not supported
  • src/EFCore/Properties/CoreStrings.resx: Language not supported
Comments suppressed due to low confidence (2)

src/EFCore/Metadata/Internal/ConstructorBindingFactory.cs:267

  • The empty array literal '[]' is not valid in C#; consider replacing it with an appropriate initialization such as 'new List()'.
unboundParametersList ??= [];

src/EFCore/Metadata/Builders/EntityTypeBuilder`.cs:1

  • The file name 'EntityTypeBuilder`.cs' appears to include a stray backtick; consider renaming it to 'EntityTypeBuilder.cs' for consistency.
// File name: EntityTypeBuilder`.cs

@AndriySvyryd AndriySvyryd force-pushed the Issue31237_ModelBuilding branch from 4de4d92 to cba73ee Compare April 7, 2025 19:03
@AndriySvyryd AndriySvyryd force-pushed the Issue31237_ModelBuilding branch from cba73ee to 51dee66 Compare April 9, 2025 20:35
@SamMonoRT SamMonoRT requested review from maumar and cincuranet April 9, 2025 21:29
@maumar
Copy link
Contributor

maumar commented Apr 10, 2025

:shipit: looked mostly at documentation and consistency between all the builders

@AndriySvyryd AndriySvyryd force-pushed the Issue31237_ModelBuilding branch from 06ec635 to faac196 Compare April 11, 2025 00:25
@AndriySvyryd AndriySvyryd merged commit 33f7061 into main Apr 12, 2025
7 checks passed
@AndriySvyryd AndriySvyryd deleted the Issue31237_ModelBuilding branch April 12, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants