Skip to content

Conversation

Kloppie5
Copy link
Contributor

ConventionSet.Remove`1 has a typeparam named TImplementaion; while other typeparams in ConventionSet use the correct name TImplementation

  • I've specifically read the guidelines for contributing and seen the walkthrough
  • I've not posted a comment on an issue with a detailed description of how I am planning to contribute and have not gotten approval from a member of the team, because its a typo fix
  • The code builds, but the tests do not pass locally because I have a space in my computer name; though the change is a non-functional change, so there should logically be nothing wrong

ConventionSet.Remove`1 has a typeparam named TImplementaion; while other typeparams in ConventionSet use the correct name TImplementation
@Kloppie5 Kloppie5 requested a review from a team as a code owner May 12, 2025 13:19
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roji roji enabled auto-merge (squash) May 12, 2025 21:33
@roji roji merged commit bafe387 into dotnet:main May 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants