Skip to content

_migrationsAssemblyObject is missing from RelationalOptionsExtension copy constructor #36136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

_migrationsAssemblyObject is missing from RelationalOptionsExtension copy constructor #36136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba30f22
Initial plan for issue
Copilot May 24, 2025
b9b9cf8
Add missing _migrationsAssemblyObject assignment in RelationalOptions…
Copilot May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/EFCore.Relational/Infrastructure/RelationalOptionsExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ protected RelationalOptionsExtension(RelationalOptionsExtension copyFrom)
_useRelationalNulls = copyFrom._useRelationalNulls;
_querySplittingBehavior = copyFrom._querySplittingBehavior;
_migrationsAssembly = copyFrom._migrationsAssembly;
_migrationsAssemblyObject = copyFrom._migrationsAssemblyObject;
_migrationsHistoryTableName = copyFrom._migrationsHistoryTableName;
_migrationsHistoryTableSchema = copyFrom._migrationsHistoryTableSchema;
_executionStrategyFactory = copyFrom._executionStrategyFactory;
Expand Down
22 changes: 22 additions & 0 deletions test/EFCore.Relational.Tests/Infrastructure/RelationalOptionsExtensionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Reflection;
using Microsoft.EntityFrameworkCore.TestUtilities.FakeProvider;

// ReSharper disable InconsistentNaming
Expand Down Expand Up @@ -94,4 +95,25 @@ public void Throws_if_MinBatchSize_out_of_range()
RelationalStrings.InvalidMinBatchSize(-1),
Assert.Throws<InvalidOperationException>(
() => new FakeRelationalOptionsExtension().WithMinBatchSize(-1)).Message);

[ConditionalFact]
public void MigrationsAssemblyObject_is_preserved_after_cloning()
{
var optionsExtension = new FakeRelationalOptionsExtension();

// Get the current executing assembly
var assembly = Assembly.GetExecutingAssembly();

// Set the migrations assembly
optionsExtension = (FakeRelationalOptionsExtension)optionsExtension.WithMigrationsAssembly(assembly);

// Verify the migrations assembly object is set
Assert.Same(assembly, optionsExtension.MigrationsAssemblyObject);

// Clone the options by using another With method (which internally calls Clone())
optionsExtension = (FakeRelationalOptionsExtension)optionsExtension.WithCommandTimeout(100);

// Verify the migrations assembly object is still preserved after cloning
Assert.Same(assembly, optionsExtension.MigrationsAssemblyObject);
}
}