Tiny fixup to #36232 #36268
Merged
Tiny fixup to #36232 #36268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
SamMonoRT
previously approved these changes
Jun 19, 2025
roji
dismissed
SamMonoRT’s stale review
Pushed some additional non-trivial changes.
|
The original approach in #36232 turned out to be a bit problematic - in addition to actually setting the column, this reverts a bit of that logic. The new Column property of ColumnExpression is now just an additional thing, and we don't infer either the name of the nullability of the ColumnExpression from it. /cc @cincuranet who originally reviewed #36232, can you take another look? (or @SamMonoRT if you're interested, obviously) |
cincuranet
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot one important bit in #36232 🤦