Fix overflow in Cosmos tests #36275
Merged
Fix overflow in Cosmos tests #36275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndriySvyryd note CI test failures |
AndriySvyryd
force-pushed
the
FixCosmosTests
branch
from
3aa836f to
5dbc1c2
Compare
roji
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
@AndriySvyryd wasn't the intention here was to specifically check the correct serialization of minimum/maximum values? If so and MaxValue causes a problem specifically with Cosmos, we should maybe modify the test data only for Cosmos to keep it being tested properly elsewhere.
But approving anyway as I don't think the min/max value verification is that important - up to you.
I agree, I doubt that these values would uncover any regressions in our code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.