Reorganize relationship tests #36298
Conversation
| throw new InvalidOperationException( | ||
| RelationalStrings.JsonEntityOrCollectionProjectedAtRootLevelInTrackingQuery( | ||
| nameof(EntityFrameworkQueryableExtensions.AsNoTracking))); | ||
| throw new InvalidOperationException(CoreStrings.OwnedEntitiesCannotBeTrackedWithoutTheirOwner); |
There was a problem hiding this comment.
This is the only product change in this PR; it uses the core error message instead of having a separate relational one that says largely the same thing.
| .IsRequired(false); | ||
|
|
||
| modelBuilder.Entity<RelationshipsRootEntity>() | ||
| // TODO: Why is this a navigation and not a complex property? |
There was a problem hiding this comment.
Have you found out the answer?
There was a problem hiding this comment.
Nope :) But I've already rewritten this most of this anyway as part of implement the complex type tests, so it's no longer going to be there.
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| // All tests in OwnedNavigationsProjectionSqliteTest currently fail because of #26708 | ||
| // (Stop generating composite keys for owned collections on SQLite) |
There was a problem hiding this comment.
It seemed like a good idea just for documentation purposes, i.e. we have all files for all mapping modes, but irrelevant/problematic ones just have a comment explaining what's going on. Let me know if this bothers you, I can remove.
There was a problem hiding this comment.
Since there is no code in this file there's a high chance that it will become outdated with the next refactoring. I think the comment in SqliteComplianceTest.cs is more than enough
In preparation for complex type query work (dotnet#36296)
In preparation for complex type query work (#36296).
This is a 99.9% test-only change, reorganizing the recently-added relationship tests.