Add basic update pipeline support for complex properties mapped to JSON #36379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue31252_Update
branch
2 times, most recently
from
e40075a to
a884308
Compare
roji
approved these changes
Jul 17, 2025
| var jsonPartialUpdateInfo = new JsonPartialUpdateInfo(); | ||
| jsonPartialUpdateInfo.Path.Insert(0, new JsonPartialUpdatePathEntry("$", null, entry, Navigation: null, ComplexProperty: complexProperty)); | ||
| jsonPartialUpdateInfo.PropertyValue = entry.GetCurrentValue(complexProperty); | ||
| jsonColumnsUpdateMap[jsonColumn] = jsonPartialUpdateInfo; |
There was a problem hiding this comment.
I don't have the full context, but it seems odd that we populate this map and then iterate over it to process it - can we simply extract the code below to a local function and call that instead of having the intermediate map? I guess we'd still need a bit of tracking to ensure we don't handle the same JSON column (though I'm assuming mapping two navigations/complex properties to the same JSON column isn't supported?).
There was a problem hiding this comment.
Yes, all this refactoring will come later
test/EFCore.Relational.Specification.Tests/Update/ComplexCollectionJsonUpdateTestBase.cs
Show resolved
Hide resolved
test/EFCore.Relational.Specification.Tests/Update/ComplexCollectionJsonUpdateTestBase.cs
Show resolved
Hide resolved
AndriySvyryd
force-pushed
the
Issue31237_PropertyValues
branch
3 times, most recently
from
e9d8fc2 to
bfa6a86
Compare
AndriySvyryd
force-pushed
the
Issue31252_Update
branch
from
a884308 to
12301c0
Compare
AndriySvyryd
force-pushed
the
Issue31237_PropertyValues
branch
from
bfa6a86 to
af9e1dc
Compare
AndriySvyryd
force-pushed
the
Issue31252_Update
branch
from
12301c0 to
aa2831d
Compare
AndriySvyryd
force-pushed
the
Issue31237_PropertyValues
branch
from
af9e1dc to
1b05bed
Compare
AndriySvyryd
force-pushed
the
Issue31252_Update
branch
from
aa2831d to
fe43fd3
Compare
AndriySvyryd
added a commit
that referenced
this pull request
Jul 18, 2025
roji
added a commit
to roji/efcore
that referenced
this pull request
Jul 19, 2025
Now that the update pipeline works, dotnet#36379
roji
added a commit
to roji/efcore
that referenced
this pull request
Jul 20, 2025
Now that the update pipeline works, dotnet#36379
roji
added a commit
to roji/efcore
that referenced
this pull request
Jul 20, 2025
Now that the update pipeline works, dotnet#36379
roji
added a commit
to roji/efcore
that referenced
this pull request
Jul 20, 2025
Now that the update pipeline works, dotnet#36379
roji
added a commit
to roji/efcore
that referenced
this pull request
Jul 21, 2025
Now that the update pipeline works, dotnet#36379
roji
added a commit
to roji/efcore
that referenced
this pull request
Jul 21, 2025
Now that the update pipeline works, dotnet#36379
roji
added a commit
that referenced
this pull request
Jul 21, 2025
Now that the update pipeline works, #36379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #31252
It still needs to be refactored and usages of
IInternalEntryshould be replaced with a new public interface