Skip to content

[TEST ONLY] Remove sync from primitive collection tests #36452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
+2,473 −3,046
Merged

[TEST ONLY] Remove sync from primitive collection tests #36452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,921 changes: 823 additions & 1,098 deletions test/EFCore.Cosmos.FunctionalTests/Query/PrimitiveCollectionsQueryCosmosTest.cs
View file
Open in desktop

Large diffs are not rendered by default.

28 changes: 13 additions & 15 deletions ...FCore.Relational.Specification.Tests/Query/PrimitiveCollectionsQueryRelationalTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,19 @@ namespace Microsoft.EntityFrameworkCore.Query;
public class PrimitiveCollectionsQueryRelationalTestBase<TFixture>(TFixture fixture) : PrimitiveCollectionsQueryTestBase<TFixture>(fixture)
where TFixture : PrimitiveCollectionsQueryTestBase<TFixture>.PrimitiveCollectionsQueryFixtureBase, new()
{
[ConditionalTheory]
[MemberData(nameof(IsAsyncData))]
public override async Task Inline_collection_Count_with_zero_values(bool async)
[ConditionalFact]
public override async Task Inline_collection_Count_with_zero_values()
{
var exception = await Assert.ThrowsAsync<InvalidOperationException>(() => base.Inline_collection_Count_with_zero_values(async));
var exception = await Assert.ThrowsAsync<InvalidOperationException>(() => base.Inline_collection_Count_with_zero_values());

Assert.Equal(RelationalStrings.EmptyCollectionNotSupportedAsInlineQueryRoot, exception.Message);
}

public override Task Column_collection_Concat_parameter_collection_equality_inline_collection(bool async)
=> AssertTranslationFailed(() => base.Column_collection_Concat_parameter_collection_equality_inline_collection(async));
public override Task Column_collection_Concat_parameter_collection_equality_inline_collection()
=> AssertTranslationFailed(base.Column_collection_Concat_parameter_collection_equality_inline_collection);

public override Task Column_collection_equality_inline_collection_with_parameters(bool async)
=> AssertTranslationFailed(() => base.Column_collection_equality_inline_collection_with_parameters(async));
public override Task Column_collection_equality_inline_collection_with_parameters()
=> AssertTranslationFailed(base.Column_collection_equality_inline_collection_with_parameters);

[ConditionalFact]
public override void Parameter_collection_in_subquery_and_Convert_as_compiled_query()
Expand All @@ -36,24 +35,23 @@ public override void Parameter_collection_in_subquery_and_Convert_as_compiled_qu
Assert.Contains("in the SQL tree does not have a type mapping assigned", exception.Message);
}

public override async Task Parameter_collection_in_subquery_Union_another_parameter_collection_as_compiled_query(bool async)
public override async Task Parameter_collection_in_subquery_Union_another_parameter_collection_as_compiled_query()
{
var message = (await Assert.ThrowsAsync<InvalidOperationException>(
() => base.Parameter_collection_in_subquery_Union_another_parameter_collection_as_compiled_query(async))).Message;
base.Parameter_collection_in_subquery_Union_another_parameter_collection_as_compiled_query)).Message;

Assert.Equal(RelationalStrings.SetOperationsRequireAtLeastOneSideWithValidTypeMapping("Union"), message);
}

public override async Task Project_inline_collection_with_Concat(bool async)
public override async Task Project_inline_collection_with_Concat()
{
var message = (await Assert.ThrowsAsync<InvalidOperationException>(
() => base.Project_inline_collection_with_Concat(async))).Message;
var message = (await Assert.ThrowsAsync<InvalidOperationException>(base.Project_inline_collection_with_Concat)).Message;

Assert.Equal(RelationalStrings.InsufficientInformationToIdentifyElementOfCollectionJoin, message);
}

// TODO: Requires converting the results of a subquery (relational rowset) to a primitive collection for comparison,
// not yet supported (#33792)
public override async Task Column_collection_Where_equality_inline_collection(bool async)
=> await AssertTranslationFailed(() => base.Column_collection_Where_equality_inline_collection(async));
public override async Task Column_collection_Where_equality_inline_collection()
=> await AssertTranslationFailed(base.Column_collection_Where_equality_inline_collection);
}
Loading