Merge ResourceMonitoringOptions.Linux.cs into ResourceMonitoringOptions.cs #5580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenyfedorov2
approved these changes
Oct 29, 2024
|
Hi @RussKie , could you please help trigger the extensions-ci pipeline? Looks like it's stuck at somewhere and not running. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResourceMonitoringOptions.Linux.csis being used in both Windows (WindowsSnapshotProvider.cs&WindowsContainerSnapshotProvider.cs) and Linux(LinuxUtilizationProvider.cs).So, I merge the
ResourceMonitoringOptions.Linux.cspartial file intoResourceMonitoringOptions.cs.Most code lines are copy-paste from
ResourceMonitoringOptions.Linux.cstoResourceMonitoringOptions.cs, while I remove the confusing method header comments like the following:extensions/src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ResourceMonitoringOptions.Linux.cs
Line 22 in 0ce85d2
Microsoft Reviewers: Open in CodeFlow