Plug JsonSchemaExporter test data to the AIJsonUtilities tests #5590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
commented
Oct 31, 2024
eiriktsarpalis
commented
Oct 31, 2024
src/Libraries/Microsoft.Extensions.AI.Abstractions/Utilities/AIJsonUtilities.Schema.cs
Outdated
Show resolved
Hide resolved
…IJsonUtilities.Schema.cs
stephentoub
reviewed
Oct 31, 2024
src/Libraries/Microsoft.Extensions.AI.Abstractions/Utilities/AIJsonUtilities.Schema.cs
Show resolved
Hide resolved
stephentoub
reviewed
Oct 31, 2024
test/Libraries/Microsoft.Extensions.AI.Abstractions.Tests/Utilities/AIJsonUtilitiesTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 31, 2024
stephentoub
approved these changes
Oct 31, 2024
joperezr
pushed a commit
to joperezr/extensions
that referenced
this pull request
Nov 5, 2024
…t#5590) * Plug JsonSchemaExporter test data to the AIJsonUtilities tests * Update src/LegacySupport/DiagnosticAttributes/README.md * Update src/Libraries/Microsoft.Extensions.AI.Abstractions/Utilities/AIJsonUtilities.Schema.cs * Address feedback.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #5582
Microsoft Reviewers: Open in CodeFlow