Publish the AotCompatibility.TestApp project as part of PR validation #5622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unnecessary code in Program.cs by turning off ReferenceTrimmer - Make the project publishable without passing in a TFM by only targeting a single TFM
Include the rest of the libraries in the repo
- Ensure clean uses the same configuration as publish - Fix part of Compliance.Redaction trimming issues by reenabling the Config Binder source generator.
eerhardt
requested review from
stephentoub,
eiriktsarpalis,
RussKie and
joperezr
eerhardt
changed the title
joperezr
reviewed
Nov 11, 2024
...oft.Extensions.AotCompatibility.TestApp/Microsoft.Extensions.AotCompatibility.TestApp.csproj
Outdated
Show resolved
Hide resolved
joperezr
approved these changes
Nov 11, 2024
...oft.Extensions.AotCompatibility.TestApp/Microsoft.Extensions.AotCompatibility.TestApp.csproj
Outdated
Show resolved
Hide resolved
|
Contributes to #5571 |
eiriktsarpalis
approved these changes
Nov 12, 2024
* Read working set from Environment in ProcessInfo since it has better performance. * Add unit test for ProcessInfo. * Remove OSSkipCondition tag from process info unit test since it's cross-platform. * Use Environment.WorkingSet in GetMemoryUsageInBytes.
…e code coverage errors." This reverts commit 47beb96.
RussKie
reviewed
Nov 12, 2024
...oft.Extensions.AotCompatibility.TestApp/Microsoft.Extensions.AotCompatibility.TestApp.csproj
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #5571
Microsoft Reviewers: Open in CodeFlow