Skip to content

Ensure the Ollama clients validate HTTP status codes. #5821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2025
Merged

Ensure the Ollama clients validate HTTP status codes. #5821

merged 2 commits into from
Jan 28, 2025

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Jan 28, 2025 •
edited by dotnet-policy-service bot
Loading

Fix #5820.

Microsoft Reviewers: Open in CodeFlow

@eiriktsarpalis eiriktsarpalis self-assigned this Jan 28, 2025
@eiriktsarpalis eiriktsarpalis requested a review from a team as a code owner January 28, 2025 15:55
@stephentoub stephentoub enabled auto-merge (squash) January 28, 2025 15:58
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 77.82 🔻
Microsoft.Extensions.AI.Ollama Line 80 77.96 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.OpenAI 77 78
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=932215&view=codecoverage-tab

@stephentoub stephentoub merged commit 67bed79 into dotnet:main Jan 28, 2025
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
@jeffhandley jeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-ai Microsoft.Extensions.AI libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OllamaChatClient doesn't check for status code before deserializing.
4 participants
@eiriktsarpalis @dotnet-comment-bot @stephentoub @jeffhandley