Initial chat template #5837

SteveSandersonMS · 2025-02-03T10:44:19Z

Microsoft Reviewers: Open in CodeFlow

dotnet-comment-bot · 2025-02-03T11:29:54Z

‼️ Found issues ‼️

Project	Coverage Type	Expected	Actual
Microsoft.Extensions.AI.Ollama	Line	80	78.25 🔻
Microsoft.Gen.MetadataExtractor	Line	98	57.35 🔻
Microsoft.Gen.MetadataExtractor	Branch	98	62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project	Expected	Actual
Microsoft.Extensions.AI.OpenAI	77	78
Microsoft.Extensions.AI	88	89
Microsoft.Extensions.AI.Abstractions	83	84

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=938045&view=codecoverage-tab

...ProjectTemplates/Microsoft.Extensions.AI.Templates/src/MyApp1/.template.config/template.json

src/ProjectTemplates/Microsoft.Extensions.AI.Templates/src/MyApp1/Program.cs

SteveSandersonMS · 2025-02-03T16:08:30Z

I'm working through the build failure by mirroring the required packages to dotnet-public.

SteveSandersonMS · 2025-02-03T16:10:57Z

@stephentoub I know you approved before but that was before I added most of the content. Do you want to look at it again or can I interpret the approval as still in effect?

We're not ready for a detailed code review on the template yet as they are still so much in flux. But several people need to collaborate on them so it's valuable to get the work-in-progress state into this repo. So my proposal is we merge this now and once @MackinnonBuck, @jmatthiesen etc are happy with the state of it, we do a more detailed review.

stephentoub · 2025-02-03T16:29:39Z

...ates/Microsoft.Extensions.AI.Templates/src/ChatWithCustomData/.template.config/template.json

+      "type": "bind",
+      "binding": "HostIdentifier"
+    },
+    "AiServiceProvider": {


Is there any way to communicate that the choice made here can easily be changed later, e.g. the Ollama section suggests that's using llama3.2, but changing that later is changing a single string. Or is that expected to be implicitly understood for templates, that choices made at setup are easily alterable later?

I have to resolve all the conversations before CI will let me merge this. I'll unresolve after it merges.

Or is that expected to be implicitly understood for templates, that choices made at setup are easily alterable later?

In general no. Choices made at setup can be arbitrarily impactful. For example in the ASP.NET Core templates, whether or not you enable auth makes a huge difference and it's very much not easy to alter it later.

I don't think we need to provide specific guidance in the template wizard about what choices are easily changeable later. At least, it's not a thing we normally do.

stephentoub · 2025-02-03T16:31:53Z

...ons.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/ChatWithCustomData.Web.csproj

+    <PackageReference Include="Azure.AI.OpenAI" Version="2.1.0" />
+#else -->
+    <PackageReference Include="Azure.AI.OpenAI" Version="2.1.0" />
+    <PackageReference Include="Microsoft.Extensions.AI.OpenAI" Version="9.1.0-preview.1.25064.3" />


Can we consolidate these versions into one place so that as we rev the template with newer M.E.AI versions, we only need to change one place?

I have to resolve all the conversations before CI will let me merge this. I'll unresolve after it merges.

Tracked in https://github.com/dotnet/ai-private-planning/issues/276

It's not straightforwards to make these versions update automatically since arcade/darc type updates have nothing to do with template contents. We would need to create a custom build step that does some kind of parameter replacement, similar to what's done for ASP.NET Core templates: https://github.com/dotnet/aspnetcore/blob/main/src/ProjectTemplates/GenerateContent.targets

stephentoub · 2025-02-03T16:32:23Z

...ons.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/ChatWithCustomData.Web.csproj

+    <PackageReference Include="Microsoft.Extensions.AI" Version="9.1.0-preview.1.25064.3" />
+    <PackageReference Include="Microsoft.SemanticKernel.Core" Version="1.34.0" />
+    <PackageReference Include="PdfPig" Version="0.1.9" />
+    <PackageReference Include="System.Linq.Async" Version="6.0.1" />


We should have this use the new System.Linq.AsyncEnumerable package as soon as the preview 1 version of it is on nuget.

I have to resolve all the conversations before CI will let me merge this. I'll unresolve after it merges.

Since it's not available yet, tracked in https://github.com/dotnet/ai-private-planning/issues/277

stephentoub · 2025-02-03T16:33:28Z

...ons.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/ChatWithCustomData.Web.csproj

+<!--#endif -->
+    <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="9.0.0" />
+    <PackageReference Include="Microsoft.Extensions.AI" Version="9.1.0-preview.1.25064.3" />
+    <PackageReference Include="Microsoft.SemanticKernel.Core" Version="1.34.0" />


SK has already bumped to 1.35. Is there any way we can tie these versions to what's automatically updated by dependabot?

I have to resolve all the conversations before CI will let me merge this. I'll unresolve after it merges.

See #5837 (comment)

....AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/Chat.razor

...es/src/ChatWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatSuggestions.razor

...sions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/Services/JsonVectorStore.cs

stephentoub · 2025-02-03T17:23:38Z

@stephentoub I know you approved before but that was before I added most of the content. Do you want to look at it again or can I interpret the approval as still in effect?

We're not ready for a detailed code review on the template yet as they are still so much in flux. But several people need to collaborate on them so it's valuable to get the work-in-progress state into this repo. So my proposal is we merge this now and once @MackinnonBuck, @jmatthiesen etc are happy with the state of it, we do a more detailed review.

Feel free to merge to unblock collaboration. I skimmed and left a few comments.

This reverts commit 5f6b171.

…oj in source control

dotnet-comment-bot · 2025-02-03T19:32:40Z

‼️ Found issues ‼️

Project	Coverage Type	Expected	Actual
Microsoft.Extensions.AI.Ollama	Line	80	78.25 🔻
Microsoft.Gen.MetadataExtractor	Line	98	57.35 🔻
Microsoft.Gen.MetadataExtractor	Branch	98	62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project	Expected	Actual
Microsoft.Extensions.AI.Abstractions	83	84
Microsoft.Extensions.AI	88	89
Microsoft.Extensions.AI.OpenAI	77	78

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=938562&view=codecoverage-tab

Building a near-empty project template

f175ae0

dotnet-policy-service bot assigned SteveSandersonMS Feb 3, 2025

SteveSandersonMS added 2 commits February 3, 2025 10:48

Declare "preview" stage

d2671eb

Avoid build error

9ef7c1b

stephentoub approved these changes Feb 3, 2025

View reviewed changes

...ProjectTemplates/Microsoft.Extensions.AI.Templates/src/MyApp1/.template.config/template.json Outdated Show resolved Hide resolved

src/ProjectTemplates/Microsoft.Extensions.AI.Templates/src/MyApp1/Program.cs Outdated Show resolved Hide resolved

SteveSandersonMS added 7 commits February 3, 2025 14:41

Reorganize projects to enable multi-project output in future

461f853

Add content

91855fd

Add symbols

4bc962e

Build fixes

15d3764

Fix content inclusion

f7559ac

Fix reference

2c3882b

Fix ingestion

c411944

SteveSandersonMS marked this pull request as ready for review February 3, 2025 16:08

SteveSandersonMS requested a review from a team as a code owner February 3, 2025 16:08

Don't build the templated project itself in CI

5f6b171

stephentoub approved these changes Feb 3, 2025

View reviewed changes

SteveSandersonMS added 2 commits February 3, 2025 18:44

Revert "Don't build the templated project itself in CI"

d6b93a0

This reverts commit 5f6b171.

To avoid build issues, have the template project csproj not be a cspr…

eda3e57

…oj in source control

SteveSandersonMS merged commit fa798ad into main Feb 3, 2025
6 checks passed

SteveSandersonMS deleted the stevesa/chat-template branch February 3, 2025 20:10

SteveSandersonMS mentioned this pull request Feb 4, 2025

Chat template CR feedback #5845

Merged

jeffhandley added the area-ai-templates Microsoft.Extensions.AI.Templates label Mar 7, 2025

github-actions bot locked and limited conversation to collaborators Apr 6, 2025

Initial chat template #5837

Initial chat template #5837

Uh oh!

Conversation

SteveSandersonMS commented Feb 3, 2025 • edited by dotnet-policy-service bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

dotnet-comment-bot commented Feb 3, 2025

Uh oh!

Uh oh!

Uh oh!

SteveSandersonMS commented Feb 3, 2025

Uh oh!

SteveSandersonMS commented Feb 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SteveSandersonMS Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephentoub commented Feb 3, 2025

Uh oh!

dotnet-comment-bot commented Feb 3, 2025

Uh oh!

Uh oh!

Uh oh!

SteveSandersonMS commented Feb 3, 2025 •

edited by dotnet-policy-service bot

Loading

SteveSandersonMS Feb 4, 2025 •

edited

Loading