Skip to content

Tweak a comment in FunctionInvokingChatClient #5910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

Tweak a comment in FunctionInvokingChatClient #5910

merged 1 commit into from
Feb 17, 2025

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Feb 15, 2025 •
edited by dotnet-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from a team as a code owner February 15, 2025 14:34
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 78.2 🔻
Microsoft.Extensions.AI.OpenAI Line 77 67.92 🔻
Microsoft.Extensions.AI.OpenAI Branch 77 49.8 🔻
Microsoft.Extensions.AI.Evaluation.Console Line 88 8.26 🔻
Microsoft.Extensions.AI.Evaluation.Console Branch 88 17.07 🔻
Microsoft.Extensions.Caching.Hybrid Line 86 82.69 🔻
Microsoft.Extensions.AI.Evaluation.Quality Line 88 7.57 🔻
Microsoft.Extensions.AI.Evaluation.Quality Branch 88 16.42 🔻
Microsoft.Extensions.AI.Evaluation.Reporting Line 88 72.06 🔻
Microsoft.Extensions.AI.Evaluation.Reporting Branch 88 64.8 🔻
Microsoft.Extensions.AI.AzureAIInference Line 91 90.09 🔻
Microsoft.Extensions.AI.AzureAIInference Branch 91 86.76 🔻
Microsoft.Extensions.AI.Abstractions Branch 83 82.85 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻
Microsoft.Extensions.AI.Evaluation Line 88 58.67 🔻
Microsoft.Extensions.AI.Evaluation Branch 88 56.67 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=953614&view=codecoverage-tab

@stephentoub stephentoub enabled auto-merge (squash) February 16, 2025 03:04
@SteveSandersonMS SteveSandersonMS mentioned this pull request Feb 17, 2025
Closed
@stephentoub stephentoub merged commit 7226fd0 into dotnet:main Feb 17, 2025
6 checks passed
@jeffhandley jeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
@rnelson rnelson mentioned this pull request Mar 12, 2025
Merged
@stephentoub stephentoub deleted the tweakcomment branch March 21, 2025 14:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

Assignees

@stephentoub stephentoub

Labels
area-ai Microsoft.Extensions.AI libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephentoub @dotnet-comment-bot @SteveSandersonMS @jeffhandley