Make MetadataExtractor & MetricsReports in Microsoft.Extensions.AuditReports create directories [Same as ComplianceReport] #5919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=954986&view=codecoverage-tab |
IbrahimMNada
changed the title
IbrahimMNada
changed the title
evgenyfedorov2
approved these changes
Feb 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with
Microsoft.Extensions.AuditReportspackage, I noticed some inconsistency while creating reports on the file system.ComplianceReportsCreates directories if they were not found, whileMetadataExtractor&MetricsReportsDo not.This pull request fix this inconsistency and enabling them all to create directory when needed.
Furthermore , it fixes some string naming bug & tweak unit test case
Should_UseProjectDir_WhenOutputPathIsRelativein theMicrosoft.Gen.MetadataExtractor.Unit.Testsnamespace.this Asp.net repository holds a sample https://github.com/IbrahimMNada/MetaDataExtractorTesting
of Microsoft.Extensions.AuditReports working with locally packed packages for testing
and here is a screen shot of the unit tests :
Microsoft Reviewers: Open in CodeFlow