-
Notifications
You must be signed in to change notification settings - Fork 827
Introduce Reason property on EvaluationMetric #6087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
5986b22
to
0f014ed
Compare
peterwald
approved these changes
Mar 12, 2025
…playing only on hover
Also fix numerous sizing and layout issues.
0f014ed
to
2116fd4
Compare
peterwald
pushed a commit
that referenced
this pull request
Mar 13, 2025
Also includes changes to the report to display this information. This addresses #6032. Additionally, this PR also includes numerous general improvements to the TypeScript report rendering - * Make the metric cards clickable and display metric details (such as diagnostics, reasons etc.) on click in a new collapsible section inline in the report (as opposed to in a hover tooltip). This addresses #6037. * Show conversations in a friendlier chat bubble form and make the sections that display conversation history collapsible so that long conversations can be collapsed. This addresses #6036 partially. * Introduce a global settings pane and move the per-textbox toggles for rendering markdown to the global location. This also addresses #6036 partially. * In the scenario tree, collapse single children into their respective parent level to reduce the amount of clicking required to expand deep trees. * Remove the scenario-level section for failure reasons since it is now possible to view failure reasons (and diagnostics) on a per-metric basis by clicking on metric cards. * A bunch of other minor layout, sizing and UX improvements and fixes for the report.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes changes to the report to display this information. This addresses #6032.
Additionally, this PR also includes numerous general improvements to the TypeScript report rendering -
Microsoft Reviewers: Open in CodeFlow