HybridCache: richer detection for field-only types (ref STJ) #6118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thought: we should explicitly restrict our override behaviour to scenarios that use the inbuilt STJ default options instance, not just ones that don't handle fields. If someone uses their own STJ options: we should respect it. The mechanism for people to do this is new and non-disclosed, so there is no issue changing that behaviour, i.e. right now the number of times anyone will have ever supplied a non-default STJ options is zero or a rounding error asymptotically approaching zero. |
DeagleGross
approved these changes
Mar 18, 2025
src/Libraries/Microsoft.Extensions.Caching.Hybrid/Internal/DefaultJsonSerializerFactory.cs
Show resolved
Hide resolved
mgravell
force-pushed
the
marc/hc_json_deep
branch
from
4f5158f to
b6e7a97
Compare
DeagleGross
approved these changes
Mar 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HybridCache uses System.Text.Json for the default serializer, which has some opinions on fields; this means that named-tuples (or value-tuples generally), and types that use value tuples or otherwise field-only values, can lose data.
We already detect value-tuples specifically as the root type, but real-world usage has highlit wider ranges of scenarios. This PR adds deeper detection for this scenario, applying the same workaround. It duly considers collection types and recursion scenarios.
fix dotnet/aspnetcore#60934
Microsoft Reviewers: Open in CodeFlow