In telemetry, treat AdditionalProperties as sensitive #6239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Apr 3, 2025
Maybe some of the functionality from the M.E redaction library would be useful. |
SteveSandersonMS
deleted the
stevesa/otel-treat-additionalproperties-as-sensitive
branch
joperezr
pushed a commit
to joperezr/extensions
that referenced
this pull request
Apr 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if
IChatClientimplementations had some way to signal which parts ofAdditionalPropertiesare sensitive and which aren't, but without some means to do that we're limited to treating it all as potentially sensitive.If this later becomes problematic, we can design some way for implementations to communicate this info. For example, we could define a
"telemetry"entry inAdditionalPropertiesthat is documented as always included in telemetry output, and then it would be up toIChatClientimplementations to put the right data there.Microsoft Reviewers: Open in CodeFlow