Skip to content

Conversation

nivebb8
Copy link
Contributor

@nivebb8 nivebb8 commented Apr 21, 2025

Missed updating the process metric in first check-in. Updating the same to use correct calculations behind the flag, and to ensure CpuUtilization() is not invoked at all.

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@evgenyfedorov2 evgenyfedorov2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change?
The ResourceUtilizationInstruments.ProcessCpuUtilization metric is deprecated (unofficially). ResourceUtilizationInstruments.ContainerCpuRequestUtilization is the replacement and it already has the right calculation logic

@dotnet-policy-service dotnet-policy-service bot added the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Apr 22, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Apr 22, 2025
@nivebb8 nivebb8 requested a review from a team as a code owner April 22, 2025 13:57
@evgenyfedorov2 evgenyfedorov2 enabled auto-merge (squash) April 22, 2025 15:37
@evgenyfedorov2 evgenyfedorov2 merged commit e5b6b02 into dotnet:main Apr 22, 2025
6 checks passed
@evgenyfedorov2
Copy link
Member

/backport to release/9.4

Copy link
Contributor

Started backporting to release/9.4: https://github.com/dotnet/extensions/actions/runs/14599507495

Copy link
Contributor

@evgenyfedorov2 an error occurred while backporting to "release/9.4", please check the run log for details!

Error: @evgenyfedorov2 is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=evgenyfedorov2

@evgenyfedorov2
Copy link
Member

/backport to release/9.4

Copy link
Contributor

Started backporting to release/9.4: https://github.com/dotnet/extensions/actions/runs/14599549296

@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants