Expose additional chat model conversion helpers #6629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Exposes the conversion routines for converting OpenAI output responses - Moves the extensions into the namespace most relevant to the performed operation
There was a problem hiding this comment.
Pull Request Overview
This PR exposes additional chat model conversion helpers by refactoring extension methods and moving them to more appropriate namespaces. The changes improve API organization by placing conversion extensions within the OpenAI namespaces most relevant to each specific operation.
- Moves conversion extension methods from
OpenAIClientExtensionsto namespace-specific extension classes - Exposes internal conversion methods to support the new public extension methods
- Fixes class naming inconsistencies (e.g.,
OpenAIAssistantChatClient→OpenAIAssistantsChatClient)
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| OpenAIClientExtensions.cs | Removes conversion extension methods and updates class references |
| MicrosoftExtensionsAIChatExtensions.cs | New extension class for OpenAI.Chat namespace conversions |
| MicrosoftExtensionsAIAssistantsExtensions.cs | New extension class for OpenAI.Assistants namespace conversions |
| MicrosoftExtensionsAIResponsesExtensions.cs | New extension class for OpenAI.Responses namespace conversions |
| MicrosoftExtensionsAIRealtimeExtensions.cs | New extension class for OpenAI.Realtime namespace conversions |
| OpenAIChatClient.cs | Exposes internal conversion method and removes unnecessary condition |
| OpenAIResponsesChatClient.cs | Fixes class name and exposes internal conversion method |
| OpenAIAssistantsChatClient.cs | Fixes class name and adds new constructor overload |
Comments suppressed due to low confidence (1)
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIResponsesChatClient.cs:26
- [nitpick] The class name change from 'OpenAIResponseChatClient' to 'OpenAIResponsesChatClient' adds an 's' but this doesn't align with the namespace 'OpenAI.Responses'. Consider 'OpenAIResponseChatClient' to match the singular form used in other similar class names in the codebase.
internal sealed class OpenAIResponsesChatClient : IChatClient
jeffhandley
approved these changes
Jul 19, 2025
This was referenced Aug 13, 2025
Merged
Closed
Closed
This was referenced Aug 15, 2025
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow