Include a trivial items keyword if missing. #6669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds handling for trivial array types in JSON schema generation to ensure they include an "items" property. The change addresses issue #6656 by modifying the schema transformation logic to automatically add an empty "items" object when processing enumerable types that don't already have this property defined.
- Adds logic to include a trivial "items" keyword for enumerable types missing this property
- Includes a new test case to verify the behavior for
object[]arrays - Updates the test JSON serialization context to support the new test type
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AIJsonUtilities.Schema.Create.cs | Adds logic to include empty "items" object for enumerable types without existing items property |
| AIJsonUtilitiesTests.cs | Adds test case and JSON serialization support for object[] to verify the fix |
src/Libraries/Microsoft.Extensions.AI.Abstractions/Utilities/AIJsonUtilities.Schema.Create.cs
Show resolved
Hide resolved
This was referenced Aug 14, 2025
Closed
Closed
This was referenced Aug 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6656.
Microsoft Reviewers: Open in CodeFlow