Add resolution of function parameter level data annotation attributes. #6671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for resolving data annotation attributes at the function parameter level when creating JSON schemas. Previously, only type-level attributes were considered, but now parameter-specific annotations like [Range] and [StringLength] are properly applied to the generated schema.
Key changes:
- Modified
CreateJsonSchemaCoreto acceptParameterInfoinstead of just the parameter name - Updated data annotation resolution to check both parameter-level and type-level attributes
- Added comprehensive test coverage for parameter-level data annotations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AIJsonUtilities.Schema.Create.cs | Modified schema creation logic to resolve attributes from both parameter info and type context |
| AIJsonUtilitiesTests.cs | Added test to verify parameter-level data annotation attributes are properly applied to JSON schema |
src/Libraries/Microsoft.Extensions.AI.Abstractions/Utilities/AIJsonUtilities.Schema.Create.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 31, 2025
test/Libraries/Microsoft.Extensions.AI.Abstractions.Tests/Utilities/AIJsonUtilitiesTests.cs
Outdated
Show resolved
Hide resolved
…ities/AIJsonUtilitiesTests.cs Co-authored-by: Stephen Toub <[email protected]>
eiriktsarpalis
commented
Jul 31, 2025
test/Libraries/Microsoft.Extensions.AI.Abstractions.Tests/Utilities/AIJsonUtilitiesTests.cs
Show resolved
Hide resolved
…ities/AIJsonUtilitiesTests.cs
This was referenced Aug 14, 2025
Closed
This was referenced Aug 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #661.
Microsoft Reviewers: Open in CodeFlow