Skip to content

Conversation

joperezr
Copy link
Member

@joperezr joperezr commented Jul 31, 2025

cc: @stephentoub @sebastienros As you were following on the fix for this after some changes in dependencies to MEAI packages. This promotes the package ref for DiagnosticSource in our api docs transport project, which fixes the version conflict.

I've tested this in an internal build that runs Source Index step and build passed.

Microsoft Reviewers: Open in CodeFlow

@Copilot Copilot AI review requested due to automatic review settings July 31, 2025 20:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a dependency version conflict in the NetSourceIndexStage1 build by promoting the DiagnosticSource package reference in the API docs transport project.

  • Adds System.Diagnostics.DiagnosticSource as an explicit package reference to resolve version conflicts
  • Follows the same pattern as the existing System.Text.Encodings.Web package reference for dependency resolution

@joperezr joperezr requested a review from stephentoub July 31, 2025 20:22
@github-actions github-actions bot added the area-ai-eval Microsoft.Extensions.AI.Evaluation and related label Jul 31, 2025
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@joperezr joperezr enabled auto-merge (squash) July 31, 2025 20:25
@joperezr joperezr merged commit 6de2ba4 into dotnet:main Jul 31, 2025
7 checks passed
This was referenced Aug 14, 2025
This was referenced Aug 27, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-ai-eval Microsoft.Extensions.AI.Evaluation and related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants