-
Notifications
You must be signed in to change notification settings - Fork 827
Fix issue with NetSourceIndexStage1 for dependency conflict versions #6672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a dependency version conflict in the NetSourceIndexStage1 build by promoting the DiagnosticSource package reference in the API docs transport project.
- Adds
System.Diagnostics.DiagnosticSource
as an explicit package reference to resolve version conflicts - Follows the same pattern as the existing
System.Text.Encodings.Web
package reference for dependency resolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
cc: @stephentoub @sebastienros As you were following on the fix for this after some changes in dependencies to MEAI packages. This promotes the package ref for DiagnosticSource in our api docs transport project, which fixes the version conflict.
I've tested this in an internal build that runs Source Index step and build passed.
Microsoft Reviewers: Open in CodeFlow