Skip to content

Consider using Environment.CpuUsage in ResourceMonitoring #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 18, 2025
Merged

Consider using Environment.CpuUsage in ResourceMonitoring #6696

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5bd5fe
Consider using Environment.CpuUsage in ResourceMonitoring
Aug 7, 2025
0fa1439
fix the warning
Aug 7, 2025
103774d
Merge branch 'main' into ykumashev/5893-environment-cpu-usage
ykumashev Aug 7, 2025
7819b95
Prefer TotalTime for readability and to avoid any double-rounding edg…
Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions ...es/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Windows/WindowsSnapshotProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
#if !NET9_0_OR_GREATER
using System.Diagnostics;
#endif
using System.Diagnostics.CodeAnalysis;
using System.Diagnostics.Metrics;
using Microsoft.Extensions.Diagnostics.ResourceMonitoring.Windows.Interop;
Expand Down Expand Up @@ -95,18 +97,31 @@ internal WindowsSnapshotProvider(

public Snapshot GetSnapshot()
{
#if NET9_0_OR_GREATER
var cpuUsage = Environment.CpuUsage;
return new Snapshot(
totalTimeSinceStart: TimeSpan.FromTicks(_timeProvider.GetUtcNow().Ticks),
kernelTimeSinceStart: cpuUsage.PrivilegedTime,
userTimeSinceStart: cpuUsage.UserTime,
memoryUsageInBytes: (ulong)Environment.WorkingSet);
#else
using var process = Process.GetCurrentProcess();

return new Snapshot(totalTimeSinceStart: TimeSpan.FromTicks(_timeProvider.GetUtcNow().Ticks),
return new Snapshot(
totalTimeSinceStart: TimeSpan.FromTicks(_timeProvider.GetUtcNow().Ticks),
kernelTimeSinceStart: process.PrivilegedProcessorTime,
userTimeSinceStart: process.UserProcessorTime,
memoryUsageInBytes: (ulong)Environment.WorkingSet);
#endif
}

internal static long GetCpuTicks()
{
#if NET9_0_OR_GREATER
return Environment.CpuUsage.TotalTime.Ticks;
#else
using var process = Process.GetCurrentProcess();
return process.TotalProcessorTime.Ticks;
#endif
}

internal static int GetCpuUnits() => Environment.ProcessorCount;
Expand Down
Loading