Skip to content

Conversation

asmirnov82
Copy link
Contributor

Change Clone method to return correct ColumnType for all inheritors of PrimitiveDataFrameColumn class. Before the fix column of parent PrimitiveDataFrameColumn was returned instead

Fixes #6127

@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@150e68f). Click here to learn what that means.
The diff coverage is 98.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6677   +/-   ##
=======================================
  Coverage        ?   68.80%           
=======================================
  Files           ?     1215           
  Lines           ?   251857           
  Branches        ?    26257           
=======================================
  Hits            ?   173280           
  Misses          ?    71765           
  Partials        ?     6812           
Flag Coverage Δ
Debug 68.80% <98.47%> (?)
production 63.32% <98.00%> (?)
test 88.88% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...crosoft.Data.Analysis/DataFrameColumnCollection.cs 79.66% <71.42%> (ø)
.../Microsoft.Data.Analysis/BooleanDataFrameColumn.cs 100.00% <100.00%> (ø)
src/Microsoft.Data.Analysis/ByteDataFrameColumn.cs 100.00% <100.00%> (ø)
src/Microsoft.Data.Analysis/CharDataFrameColumn.cs 90.90% <100.00%> (ø)
...Microsoft.Data.Analysis/DateTimeDataFrameColumn.cs 81.81% <100.00%> (ø)
.../Microsoft.Data.Analysis/DecimalDataFrameColumn.cs 90.90% <100.00%> (ø)
...c/Microsoft.Data.Analysis/DoubleDataFrameColumn.cs 100.00% <100.00%> (ø)
...rc/Microsoft.Data.Analysis/Int16DataFrameColumn.cs 100.00% <100.00%> (ø)
...rc/Microsoft.Data.Analysis/Int32DataFrameColumn.cs 100.00% <100.00%> (ø)
...rc/Microsoft.Data.Analysis/Int64DataFrameColumn.cs 100.00% <100.00%> (ø)
... and 7 more

@michaelgsharp
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for submitting this!

@michaelgsharp michaelgsharp merged commit c259a33 into dotnet:main Jun 13, 2023
@asmirnov82 asmirnov82 deleted the 6127_dataframe_merge_datatype_issue branch June 22, 2023 08:27
@JakeRadMSFT
Copy link
Contributor

Merged into Generic Math branch. (This is just a note for myself)

@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame merge results in column datatype problem
3 participants