[RGen] Add an analyzer error for views that miss initWithFrame. #23788

mandel-macaque · 2025-09-10T16:30:45Z

Add a new analyzer error that will ensure that the classes that inherit from UIView or NSView do have a initWithFrame: constructor exposed.

Copilot

Pull Request Overview

This PR adds a new analyzer error (RBI0041) to ensure that classes inheriting from UIView or NSView expose the required initWithFrame: constructor. This is a binding requirement for view classes to properly support initialization with frame rectangles.

Key changes include:

Extended type inheritance tracking to identify view classes
Added new analyzer validation for required constructors
Comprehensive test coverage for both UIView and NSView scenarios

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`TypeSymbolExtensions.Core.cs`	Added view detection logic and updated inheritance tracking method signature
`SemanticModelExtensions.Generator.cs`	Extended symbol data extraction to include TypeInfo parameter
`TypeInfo.cs` & `TypeInfo.Transformer.cs`	Added IsView property to track view inheritance
`Binding.cs` & `Binding.Generator.cs`	Added TypeInfo field to binding data model
`ClassValidator.cs`	Implemented validation logic for required constructors
`RgenDiagnostics.cs` & `Resources.resx`	Added RBI0041 diagnostic descriptor and messages
Test files	Added comprehensive test coverage for the new analyzer functionality

Files not reviewed (1)

src/rgen/Microsoft.Macios.Bindings.Analyzer/Resources.Designer.cs: Language not supported

Copilot · 2025-09-10T16:31:22Z

src/rgen/Microsoft.Macios.Generator/DataModel/TypeInfo.cs

+	/// </summary>
+	public bool IsView {
+		get => isView;
+		init => isView= value;


Missing space before assignment operator. Should be isView = value;

Copilot · 2025-09-10T16:31:23Z

tests/rgen/Microsoft.Macios.Bindings.Analyzer.Tests/ClassAnalyzerTests.cs

+			diagnostic: analyzerDiagnotics [0], 
+			diagnosticId: "RBI0041",
+			severity: DiagnosticSeverity.Error, 
+			message: "The class 'TestClass' inherits from UIView but does not expose a 'initWithFrame:' constructor");


The error message is incorrect for NSView test case. It should say 'inherits from NSView' instead of 'inherits from UIView' for the NSViewInitWithFrameMissing test.

Suggested change

message: "The class 'TestClass' inherits from UIView but does not expose a 'initWithFrame:' constructor");

message: "The class 'TestClass' inherits from NSView but does not expose a 'initWithFrame:' constructor");

src/rgen/Microsoft.Macios.Bindings.Analyzer/Resources.resx

Co-authored-by: Copilot <[email protected]>

rolfbjarne

Did we miss this in our existing bindings somewhere?

Also I'm not sure this is correct: there's no reason a UIView subclass can't offer a different constructor (say "initWithFrame:someOtherOption:" and then call UIView's "initWithFrame:" ctor)

1. Remove old comment and provide a correct one 2. Provide the protocol name in the error RI00041

vs-mobiletools-engineering-service2 · 2025-09-17T14:58:05Z

✅ [CI Build #769e2f2] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 769e2f225f14c0d40ac12abe169a36e644e5d22a [PR build]

vs-mobiletools-engineering-service2 · 2025-09-17T14:58:07Z

✅ [PR Build #769e2f2] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 769e2f225f14c0d40ac12abe169a36e644e5d22a [PR build]

vs-mobiletools-engineering-service2 · 2025-09-17T15:23:57Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 769e2f225f14c0d40ac12abe169a36e644e5d22a [PR build]

vs-mobiletools-engineering-service2 · 2025-09-17T15:28:13Z

✅ [CI Build #769e2f2] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 769e2f225f14c0d40ac12abe169a36e644e5d22a [PR build]

vs-mobiletools-engineering-service2 · 2025-09-17T15:40:28Z

💻 [CI Build #769e2f2] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 769e2f225f14c0d40ac12abe169a36e644e5d22a [PR build]

vs-mobiletools-engineering-service2 · 2025-09-17T15:42:34Z

💻 [CI Build #769e2f2] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 769e2f225f14c0d40ac12abe169a36e644e5d22a [PR build]

vs-mobiletools-engineering-service2 · 2025-09-17T15:43:23Z

💻 [CI Build #769e2f2] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 769e2f225f14c0d40ac12abe169a36e644e5d22a [PR build]

vs-mobiletools-engineering-service2 · 2025-09-17T15:47:16Z

💻 [CI Build #769e2f2] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 769e2f225f14c0d40ac12abe169a36e644e5d22a [PR build]

vs-mobiletools-engineering-service2 · 2025-09-18T11:37:49Z

🚀 [CI Build #769e2f2] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 769e2f225f14c0d40ac12abe169a36e644e5d22a [PR build]

[RGen] Add an analyzer error for views that miss initWithFrame.

e7bdc2e

Add a new analyzer error that will ensure that the classes that inherit from UIView or NSView do have a initWithFrame: constructor exposed.

mandel-macaque requested review from Copilot and rolfbjarne September 10, 2025 16:30

Copilot AI reviewed Sep 10, 2025

View reviewed changes

GitHub Actions Autoformatter and others added 2 commits September 10, 2025 16:35

Auto-format source code

a39e9ae

Update src/rgen/Microsoft.Macios.Bindings.Analyzer/Resources.resx

3f8302c

Co-authored-by: Copilot <[email protected]>

This comment has been minimized.

Sign in to view

rolfbjarne reviewed Sep 10, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque and others added 2 commits September 17, 2025 10:26

Address code review:

f20a288

1. Remove old comment and provide a correct one 2. Provide the protocol name in the error RI00041

Auto-format source code

769e2f2

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 2b6451b into main Sep 18, 2025
40 checks passed

mandel-macaque deleted the dev/mandel/constructors-uikit branch September 18, 2025 11:55

	message: "The class 'TestClass' inherits from UIView but does not expose a 'initWithFrame:' constructor");
	message: "The class 'TestClass' inherits from NSView but does not expose a 'initWithFrame:' constructor");

[RGen] Add an analyzer error for views that miss initWithFrame. #23788

[RGen] Add an analyzer error for views that miss initWithFrame. #23788

Uh oh!

Conversation

mandel-macaque commented Sep 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 17, 2025

✅ [CI Build #769e2f2] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 17, 2025

✅ [PR Build #769e2f2] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 17, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 17, 2025

✅ [CI Build #769e2f2] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 17, 2025

💻 [CI Build #769e2f2] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 17, 2025

💻 [CI Build #769e2f2] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 17, 2025