Skip to content

[Reverted] ToolbarItem behavior with ImageSource iOS - fix #28833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

[Reverted] ToolbarItem behavior with ImageSource iOS - fix #28833

merged 2 commits into from
Jun 2, 2025

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Apr 7, 2025 •
edited by PureWeen
Loading

Reverted

#31112

Issues Fixed

Fixes #28822

Before After

@Copilot Copilot AI review requested due to automatic review settings April 7, 2025 17:42
@kubaflo kubaflo requested a review from a team as a code owner April 7, 2025 17:42
@kubaflo kubaflo self-assigned this Apr 7, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot
Copilot AI reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28822.cs:20

  • [nitpick] Consider adding explicit assertions to verify that each ToolbarItem renders as expected rather than solely depending on screenshot comparison.
VerifyScreenshot();

src/Controls/tests/TestCases.HostApp/Issues/Issue28822.cs:13

  • [nitpick] Consider adding AutomationIds to the ToolbarItems in order to facilitate more granular UI tests in the future.
ToolbarItems.Add(new ToolbarItem()

src/Controls/src/Core/Compatibility/iOS/Extensions/ToolbarItemExtensions.cs:115

  • Consider adding a comment to explain why FontImageSource objects are excluded from the ImageWithRenderingMode processing to aid future maintainers.
Image = item.IconImageSource is not FontImageSource ? result?.Value.ImageWithRenderingMode(UIImageRenderingMode.AlwaysOriginal) : result?.Value;

@PureWeen PureWeen added this to the .NET 9 SR8 milestone May 8, 2025
@PureWeen PureWeen moved this to Ready To Review in MAUI SDK Ongoing May 8, 2025
@dotnet dotnet deleted a comment from azure-pipelines bot May 27, 2025
@dotnet dotnet deleted a comment from azure-pipelines bot May 27, 2025
@rmarinho
Copy link
Member

/rebase

@rmarinho
Copy link
Member

/azp run

@dotnet dotnet deleted a comment from jsuarezruiz May 27, 2025
@rmarinho rmarinho moved this from Ready To Review to Approved in MAUI SDK Ongoing May 27, 2025
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen changed the base branch from main to inflight/current June 2, 2025 20:13
@PureWeen PureWeen merged commit 9c890cd into dotnet:inflight/current Jun 2, 2025
125 of 129 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Jun 2, 2025
github-actions bot pushed a commit that referenced this pull request Jun 6, 2025
@kubaflo @PureWeen
ToolbarItem behavior with ImageSource iOS - fix (#28833)
2a0aa09 
* ToolbarItem behavior with ImageSource iOS - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jun 6, 2025
@kubaflo @PureWeen
ToolbarItem behavior with ImageSource iOS - fix (#28833)
db369ea 
* ToolbarItem behavior with ImageSource iOS - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jun 7, 2025
@kubaflo @rmarinho
ToolbarItem behavior with ImageSource iOS - fix (#28833)
ec68db2 
* ToolbarItem behavior with ImageSource iOS - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jun 10, 2025
@kubaflo @PureWeen
ToolbarItem behavior with ImageSource iOS - fix (#28833)
c93de35 
* ToolbarItem behavior with ImageSource iOS - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jun 10, 2025
@kubaflo @PureWeen
ToolbarItem behavior with ImageSource iOS - fix (#28833)
5270d80 
* ToolbarItem behavior with ImageSource iOS - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
@kubaflo @PureWeen
ToolbarItem behavior with ImageSource iOS - fix (#28833)
6adcb1f 
* ToolbarItem behavior with ImageSource iOS - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
@kubaflo @PureWeen
ToolbarItem behavior with ImageSource iOS - fix (#28833)
d47ec75 
* ToolbarItem behavior with ImageSource iOS - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jun 16, 2025
@kubaflo @PureWeen
ToolbarItem behavior with ImageSource iOS - fix (#28833)
7cc5334 
* ToolbarItem behavior with ImageSource iOS - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jun 16, 2025
@kubaflo @PureWeen
ToolbarItem behavior with ImageSource iOS - fix (#28833)
48448ee 
* ToolbarItem behavior with ImageSource iOS - fix

* Added snapshots
github-actions bot pushed a commit that referenced this pull request Jun 19, 2025
@kubaflo @PureWeen
ToolbarItem behavior with ImageSource iOS - fix (#28833)
5860fe6 
* ToolbarItem behavior with ImageSource iOS - fix

* Added snapshots
@PureWeen PureWeen mentioned this pull request Jun 20, 2025
Merged
PureWeen added a commit that referenced this pull request Jun 21, 2025
@PureWeen
[2025/06/16] Candidate - In Flight Branch (#29886)
e863130 
For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process

# .NET MAUI Release Notes - inflight/candidate Branch

## MAUI Product Fixes
* [iOS] Fix SwipeView programmatic open when background color is set by
@Shalini-Ashokan in #29765
* [iOS] FormattedText with text color causes stack overflow - fix by
@kubaflo in #29874
* [iOS] Fix AdaptiveTrigger not working as expected by @jsuarezruiz in
#20987
* [iOS] Fix for Flyout title is not broken over multiple lines when you
rotate your screen by @BagavathiPerumal in
#29171
* [Windows] Fix for Assigning null to the SelectedItem of the
CollectionView in the SelectionChanged event does not clear the
selection by @SyedAbdulAzeemSF4852 in
#29288
* Fix TapCoordinates method in Catalyst by @jsuarezruiz in
#29775
* Fixed ItemSpacing on CarouselView resizes items [Android] by
@Dhivya-SF4094 in #29796
* Perf : ButtonContentTypeConverter now using InvariantCulture to parse
double by @antoine-jonathan in #25393
* ToolbarItem behavior with ImageSource iOS - fix by @kubaflo in
#28833
* [Android] Fixed Button Shadow Color Transparency Not Applied Correctly
by @NanthiniMahalingam in #29371
* Don't call NSAttributedString with HTML from a background thread by
@kubaflo in #26153
* [Windows] Implemented the Resize and Downsize functions in the
W2DImage class by @HarishwaranVijayakumar in
#29138
* Templated indicator view - improvements by @kubaflo in
#25642
* Update Issue25946.xaml by @anandhan-rajagopal in
#30025

## Testing
* Fixed Test case failure in PR 26153 - iOS by @kubaflo in
#29906
* Fixed Test case failure in PR 25642 - snapshots by @kubaflo in
#29881
* [Testing] Feature Matrix UITest Cases for RadioButton by
@TamilarasanSF4853 in #29744
* [Testing] Feature Matrix UITest Cases for CollectionView ItemsSource
Feature by @LogishaSelvarajSF4525 in
#29322
* [Testing] Feature Matrix UITest Cases for Stepper by
@nivetha-nagalingam in #29731
* [Testing] Feature Matrix UITest Cases for CheckBox Control by
@anandhan-rajagopal in #29739
* Update the comment for the test properties by @mattleibow in
#27306

## Dependency Updates
* No changes in this category

## Docs
* No changes in this category

## Housekeeping
* [create-pull-request] automated change by @github-actions[bot] in
#29875
* [create-pull-request] automated change by @github-actions[bot] in
#29792
* [create-pull-request] automated change by @github-actions[bot] in
#29760

**Full Changelog**:
origin/main...origin/inflight/candidate
@PureWeen PureWeen modified the milestones: .NET 9 SR8, .NET 9 SR9 Jun 23, 2025
rmarinho pushed a commit that referenced this pull request Jun 24, 2025
@kubaflo @rmarinho
ToolbarItem behavior with ImageSource iOS - fix (#28833)
49ccf35 
* ToolbarItem behavior with ImageSource iOS - fix

* Added snapshots
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2025
@PureWeen PureWeen changed the title ToolbarItem behavior with ImageSource iOS - fix [Reverted] ToolbarItem behavior with ImageSource iOS - fix Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@jsuarezruiz jsuarezruiz jsuarezruiz requested changes

@rmarinho rmarinho rmarinho approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix was automatically assigned from dotnet/dotnet-maui-reviewers

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow was automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

@kubaflo kubaflo

Labels
area-controls-toolbar ToolBar community ✨ Community Contribution platform/ios
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 9 SR9
Development

Successfully merging this pull request may close these issues.

ToolbarItem behavior with ImageSource iOS
4 participants
@kubaflo @rmarinho @jsuarezruiz @PureWeen