-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Fix : FilePicker.PickAsync Task Hangs When User Cancels the Picker in iOS #29498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey there @@bhavanesh2001! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
cc @MartyIX |
@bhavanesh2001 I made big changes for MediaPicker .NET 10, can you have a look if and how we should apply that there? |
/rebase |
Sorry, using this PR as a guinea pig for the PR format workflow. |
@jfversluis I verified the new MediaPicker implementation. Cancellation appears to be handled correctly — the maui/src/Essentials/src/MediaPicker/MediaPicker.ios.cs Lines 80 to 84 in 84331b3
|
/rebase |
Bhavanesh just informed me this is File picker... Not Media picker. Time for weekend... |
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Root Cause
The modern Picker API doesn't handle cancellations, so when the user dismisses the picker, the task’s result is never set.
Issues Fixed
Fixes #29490