Skip to content

Track committed usage #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2025
Merged

Track committed usage #4940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a0645a
track committed usage
VincentBu Sep 3, 2025
24ce7a7
Merge branch 'dotnet:main' into TrackCommittedUsage
VincentBu Sep 8, 2025
42adc7e
replace sum with average
VincentBu Sep 8, 2025
5ec56d7
return double.NaN in case divide by zero
VincentBu Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...nchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/Presentation/GCPerfSim/ResultItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ private ResultItem(string runName, string corerun)
FirstToLastGCSeconds = double.NaN;
HeapSizeBeforeMB_Mean = double.NaN;
HeapSizeAfter_Mean = double.NaN;
TotalCommittedInUse = double.NaN;
TotalBookkeepingCommitted = double.NaN;
TotalCommittedInGlobalDecommit = double.NaN;
TotalCommittedInFree = double.NaN;
TotalCommittedInGlobalFree = double.NaN;
PauseDurationMSec_95PWhereIsGen0 = double.NaN;
PauseDurationMSec_95PWhereIsGen1 = double.NaN;
PauseDurationMSec_95PWhereIsBackground = double.NaN;
Expand Down Expand Up @@ -47,6 +52,12 @@ public ResultItem(GCProcessData processData, string runName, string configuratio
HeapSizeAfter_Mean = GoodLinq.Average(processData.GCs, (gc => gc.HeapSizeAfterMB));
HeapSizeBeforeMB_Mean = GoodLinq.Average(processData.GCs, (gc => gc.HeapSizeBeforeMB));

TotalCommittedInUse = GoodLinq.Average(processData.GCs, (gc => gc.CommittedUsageBefore.TotalCommittedInUse));
TotalBookkeepingCommitted = GoodLinq.Average(processData.GCs, (gc => gc.CommittedUsageBefore.TotalBookkeepingCommitted));
TotalCommittedInGlobalDecommit = GoodLinq.Average(processData.GCs, (gc => gc.CommittedUsageBefore.TotalCommittedInGlobalDecommit));
TotalCommittedInFree = GoodLinq.Average(processData.GCs, (gc => gc.CommittedUsageBefore.TotalCommittedInFree));
TotalCommittedInGlobalFree = GoodLinq.Average(processData.GCs, (gc => gc.CommittedUsageBefore.TotalCommittedInGlobalFree));

var properties = processData.Stats.GetType().GetProperties(System.Reflection.BindingFlags.Public | System.Reflection.BindingFlags.Instance);
foreach (var property in properties)
{
Expand Down Expand Up @@ -104,6 +115,11 @@ public ResultItem(GCProcessData processData, string runName, string configuratio
public double FirstToLastGCSeconds { get; }
public double HeapSizeBeforeMB_Mean { get; }
public double HeapSizeAfter_Mean { get; }
public double TotalCommittedInUse { get; set; }
public double TotalCommittedInGlobalDecommit { get; set; }
public double TotalCommittedInFree { get; set; }
public double TotalCommittedInGlobalFree { get; set; }
public double TotalBookkeepingCommitted { get; set; }
public double PauseDurationMSec_95PWhereIsGen0 { get; }
public double PauseDurationMSec_95PWhereIsGen1 { get; }
public double PauseDurationMSec_95PWhereIsBackground { get; }
Expand Down
22 changes: 21 additions & 1 deletion ...c/GC.Infrastructure/GC.Infrastructure.Core/Presentation/GCPerfSim/ResultItemComparison.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,27 @@ public string ToMarkdownString(string runName, string baselineCorerunName, strin
public double BaselineMetric { get; }
public double ComparandMetric { get; }
public double Delta => ComparandMetric - BaselineMetric;
public double PercentageDelta => (Delta / BaselineMetric) * 100;
public double PercentageDelta
{
get
{
if (BaselineMetric == 0)
{
if (ComparandMetric == 0)
{
return 0;
}
else
{
return double.NaN;
}
}
else
{
return Delta / BaselineMetric * 100.0;
}
}
}
public string Key => $"{Baseline.ConfigurationName}_{RunName}";
public ResultItem Baseline { get; }
public ResultItem Comparand { get; }
Expand Down