Skip to content

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented Jan 8, 2025

Related to #11358

Discovered another unused field to be removed.

@mthalman mthalman requested a review from a team as a code owner January 8, 2025 00:29
@davidwengier davidwengier enabled auto-merge January 8, 2025 01:07
@davidwengier davidwengier merged commit 2f68db6 into dotnet:main Jan 8, 2025
12 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jan 8, 2025
davidwengier added a commit that referenced this pull request Jan 8, 2025
Fixes #11359

IDE0052 wasn't being enforced in CI which means we broke the VMR build
(see #11358 and
#11361). This change makes sure this
rule is turned on and enforced in command line builds, and fixes a
couple of violations in the compiler. Should prevent future breakages
too.

Not sure why out existing .editorconfig for this diagnostic didn't work,
but I suspect its because the compiler has its own .editorconfig marked
as root.
@jjonescz jjonescz modified the milestones: Next, 17.14 P1 Mar 11, 2025
@mthalman mthalman deleted the patch3 branch March 27, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants