Don't create overlapping changes when doing additional formatting #11413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Jan 24, 2025
| } | ||
|
|
||
| if (closeBraceNode.TryGetLinePositionSpanWithoutWhitespace(source, out var closeBraceRange) && | ||
| if (closeBraceNode.Span.Length > 0 && |
There was a problem hiding this comment.
Without this line, the test on the syntactically invalid document failed, because the compiler apparently adds an empty node at position 0 for the close brace on an invalid document.
ryzngard
reviewed
Jan 24, 2025
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/Passes/RazorFormattingPass.cs
Outdated
Show resolved
Hide resolved
ryzngard
approved these changes
Jan 24, 2025
This was referenced Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2347107
First commit fixes the bug in the new formatting engine where we sometimes create overlapping edits, and instead now we drop those edits on the floor, so at least most of the file will format correctly.
Second commit then fixes the actual formatting issue with the code in hand, which means we no longer have overlapping edits in the first place.