Skip to content

Make logging fall into the pit of success #11581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Make logging fall into the pit of success #11581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion ...oft.CodeAnalysis.Razor.Workspaces/Logging/Handlers/LogMessageInterpolatedStringHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
using System.Runtime.CompilerServices;
using System.Text;
using Microsoft.AspNetCore.Razor.PooledObjects;
using Microsoft.VisualStudio.LanguageServer.Protocol;
using Roslyn.LanguageServer.Protocol;

namespace Microsoft.CodeAnalysis.Razor.Logging;

Expand Down Expand Up @@ -32,7 +34,7 @@ public void AppendLiteral(string s)

public void AppendFormatted<T>(T t)
{
_builder.Object.Append(t?.ToString() ?? "[null]");
_builder.Object.Append(GetMessage(t));
}

public void AppendFormatted<T>(T t, string format)
Expand All @@ -46,4 +48,19 @@ public override string ToString()
_builder.Dispose();
return result;
}

private static string GetMessage(object? value)
=> value switch
{
VisualStudio.LanguageServer.Protocol.Range range => range.ToDisplayString(),
VisualStudio.LanguageServer.Protocol.Position position => position.ToDisplayString(),
VisualStudio.LanguageServer.Protocol.ISumType sumType => GetMessage(sumType.Value),

Roslyn.LanguageServer.Protocol.Range range => range.ToDisplayString(),
Roslyn.LanguageServer.Protocol.Position position => position.ToDisplayString(),
Roslyn.LanguageServer.Protocol.ISumType sumType => GetMessage(sumType.Value),

null => "[null]",
_ => value.ToString() ?? "[null]"
};
}