Reduce allocations in TagHelperParseTreeRewriter.Rewrite #11882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customer profile is showing a very large number of allocations in the GetAllDiagnostics call, due to the yield state machinery. Add internal method to TagHelperDescriptor that allows callers to pass in a PooledArrayBuilder for the diagnostics to be added directly to, instead of using "return yield". Partial fix for dotnet/roslyn#78639
|
@dotnet/razor-compiler for reviews |
chsienki
approved these changes
May 27, 2025
jaredpar
approved these changes
May 27, 2025
This was referenced May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer profile is showing a very large number of allocations in the GetAllDiagnostics call, due to the yield state machinery. Added internal method to TagHelperDescriptor that allows callers to pass in a PooledArrayBuilder for the diagnostics to be added directly to, instead of using "return yield".
Customer profile showed 1.2 GB(!!) of memory allocations due to this.
Partial fix for https://developercommunity.visualstudio.com/t/Razor-Development:-30-Second-CPU-Churn-A/10904811