Fix overly aggressive delegated completion #11965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were losing VSInternalCompletionContext.InvokeKind value when re-invoking completion request on delegated servers (C#, HTML). That caused default value of "Invoked" being used in delegated server, which basically means Ctrl+J/Show Completion command. That caused overly aggressive behavior as if completion was forced rather than auto-shown by typing. This change properly types Context of CompletionParams so that VSInternalCompletionContext is properly serialized/deserialized and InvokeKind value doesn't get lost.
DustinCampbell
approved these changes
Jun 20, 2025
...crosoft.CodeAnalysis.Razor.Workspaces/Protocol/Completion/RazorVSInternalCompletionParams.cs
Outdated
Show resolved
Hide resolved
...crosoft.CodeAnalysis.Razor.Workspaces/Protocol/Completion/RazorVSInternalCompletionParams.cs
Outdated
Show resolved
Hide resolved
...crosoft.CodeAnalysis.Razor.Workspaces/Protocol/Completion/RazorVSInternalCompletionParams.cs
Show resolved
Hide resolved
...crosoft.CodeAnalysis.Razor.Workspaces/Protocol/Completion/RazorVSInternalCompletionParams.cs
Show resolved
Hide resolved
Co-authored-by: Dustin Campbell <[email protected]>
Co-authored-by: Dustin Campbell <[email protected]>
davidwengier
approved these changes
Jun 20, 2025
This was referenced Jun 24, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were losing VSInternalCompletionContext.InvokeKind value when re-invoking completion request on delegated servers (C#, HTML). That caused default value of "Invoked" being used in delegated server, which basically means Ctrl+J/Show Completion command. That caused overly aggressive behavior as if completion was forced rather than auto-shown by typing.
### Summary of the changes
Fixes:
Internally filed AzDO issue