Add missing paren to SyntaxSerializer #11968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,7 +105,7 @@ private void WriteNode(SyntaxNode node) | |||
|
|
|||
| protected virtual void WriteSpan(TextSpan span) | |||
| { | |||
| WriteValue($"[{span.Start}..{span.End}{Separator}Width: {span.End - span.Start}"); | |||
| WriteValue($"[{span.Start}..{span.End}){Separator}Width: {span.End - span.Start}"); | |||
There was a problem hiding this comment.
Did you mean this?
Suggested change
| WriteValue($"[{span.Start}..{span.End}){Separator}Width: {span.End - span.Start}"); | |
| WriteValue($"[{span.Start}..{span.End}]{Separator}Width: {span.End - span.Start}"); |
There was a problem hiding this comment.
No, the end is exclusive. I think we use [x..y) to demonstrate that in other places as well. Definitely we did that here previously:
There was a problem hiding this comment.
Oh right, thanks. Looked weird out of context
chsienki
approved these changes
Jun 23, 2025
DustinCampbell
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
Thanks! I'm glad this has no product impact, since it's only used for debugging. Thankfully, I got it right in TestSyntaxSerializer. Sadly, this is one of the places where the serialization differs between debugging and test output.
333fred
approved these changes
Jun 23, 2025
This was referenced Jun 25, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paren seems to be unintentionally dropped in #11853 cc @DustinCampbell