Don't show HTML snippets in style, script, or html comment blocks #12021
Conversation
| if (RazorSyntaxFacts.IsInStyleBlock(node) | ||
| || RazorSyntaxFacts.IsInScriptBlock(node) | ||
| || RazorSyntaxFacts.IsInMarkupCommentBlock(node)) |
There was a problem hiding this comment.
Having these helper methods is nice, but I think in this case we probably want to have more explicit code, as this is currently doing 3 complete tree walks all the way up the tree, every time. Combining these into one FirstAncestorOrSelf call, would be much better. Could still use helper methods to identify the actual elements.
There was a problem hiding this comment.
Walks up the tree shouldn't be too bad, should they? Or is the razor syntax tree insanely deep?
There was a problem hiding this comment.
It's definitely not the worst thing, and I would say that most of the time Razor trees aren't very deep, no, but just seems like three walks that could be trivially combined into one is pretty low hanging fruit, and being completion its sort of on the typing path.
There was a problem hiding this comment.
As Todd, I didn't think it would be a big deal since we are really walking up just to the first containing element, which really shouldn't be too deep.
At the same time, happy to implement this, shouldn't be too bad.
Summary of the changes
Fixes:
https://developercommunity.visualstudio.com/t/Snippets-are-way-too-agressive-in-Razor-/10676182