Suggest blahAsync-style names for non-async Task-returning methods

[rchande]

[CyrusNajmabadi]

Not sure what this is asking for.

[CyrusNajmabadi]

We already suffix afaict:

[sharwell]

Reopening as we do not currently offer the Async suffix for these methods.

The naming suggestion feature is currently looking at the async keyword as a hint that the signature is asynchronous. This is not the correct behavior; the return type determines that the method has an asynchronous signature, and the async keyword is not part of the signature at all.

[cremor]

Something similar is true for the IDE1006 code-style naming rule. If you define a dotnet_naming_symbols rule with required_modifiers = async then it will only apply if the method is actually async. It will not apply for non-async methods that have awaitable return types.

It might be a bit controversal for the naming rule because you explicitly have to configure a "async modifier". But there is simply no way to configure a rule for methods with awaitable return types.