fix extra whitespace insertion for text edits #77071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
ToddGrun
reviewed
Feb 5, 2025
| Data = capabilityHelper.SupportCompletionListData ? resolveData : null | ||
| Data = capabilityHelper.SupportCompletionListData ? resolveData : null, | ||
| // By default, all text edits we create include the appropriate whitespace, so tell the client to leave it as-is. | ||
| InsertTextMode = LSP.InsertTextMode.AsIs, |
There was a problem hiding this comment.
accidentally force pushed, but fixed
ToddGrun
reviewed
Feb 5, 2025
| Data = capabilityHelper.SupportCompletionListData ? resolveData : null | ||
| Data = capabilityHelper.SupportCompletionListData ? resolveData : null, | ||
| // By default, all text edits we create include the appropriate whitespace, so tell the client to leave it as-is. | ||
| InsertTextMode = LSP.InsertTextMode.AsIs, |
There was a problem hiding this comment.
accidentally force pushed, but fixed
dibarbet
force-pushed
the
completion_whitespace
branch
from
6072e58 to
bd44932
Compare
JoeRobich
approved these changes
Feb 6, 2025
This was referenced Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue where whitespace gets added twice for completion items that have upfront text edits.