Optimize DiagnosticService on NetCore #77126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Feb 9, 2025
| // might have beaten us to storing in it. | ||
| #if NET | ||
| _projectToForceAnalysisData.TryAdd(project, box); | ||
| Contract.ThrowIfFalse(_projectToForceAnalysisData.TryGetValue(project, out box)); |
There was a problem hiding this comment.
can be replaced with GetOrAdd dotnet/runtime#111204 when we move to NET10
ToddGrun
reviewed
Feb 10, 2025
| tupleBox = new((stateSets, compilationWithAnalyzersPair)); | ||
|
|
||
| #if NET | ||
| s_projectToCompilationWithAnalyzers.AddOrUpdate(project, tupleBox); |
dibarbet
approved these changes
Feb 10, 2025
| var compilationWithAnalyzersPair = await CreateCompilationWithAnalyzersAsync().ConfigureAwait(false); | ||
| tupleBox = new((stateSets, compilationWithAnalyzersPair)); | ||
|
|
||
| #if NET |
There was a problem hiding this comment.
is this running out of proc or in-proc in VS? (curious if this only applies to VSCode)
There was a problem hiding this comment.
this runs in proc in VS currently. but i would like it to run OOP. basically, we run most of diagnostics in proc until the point of calling out to actually do the computation. i'd like to push this much higher so that we basically remote over the call to the IDiagService immediately, and do everything else on the OOP side. that is upcoming.
This was referenced Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.