Change keys for import caching #77627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
ToddGrun
reviewed
Mar 19, 2025
| s_projectItemsCache.AddOrUpdate(project.State, cacheEntry); | ||
| #else | ||
| s_projectItemsCache.Remove(project.State); | ||
| s_projectItemsCache.GetValue(project.State, _ => cacheEntry); |
There was a problem hiding this comment.
Should the result of this be put into cacheEntry?
There was a problem hiding this comment.
it should be fine either way. i prefer this way so that we ensure that we exactly return the data we computed for this exact arguments.
|
@genlu @jasonmalinowski ptal. |
|
@ToddGrun ptal. |
genlu
reviewed
Mar 20, 2025
| namespace Microsoft.VisualStudio.LanguageServices; | ||
|
|
||
| [ExportWorkspaceService(typeof(IWorkspaceCacheService), ServiceLayer.Host), Shared] | ||
| internal sealed class WorkspaceCacheService : IWorkspaceCacheService |
There was a problem hiding this comment.
huh, so this thing is not called by anyone
This was referenced Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a MetadataId ensures that the cache items for metadata only stay alive as long as the metadata does (and are released once they are). Similary, using a CWT ensures that we only keep things alive as long as something is rooting it. but we release once it is not (obviating the need for custom flushing routines).