-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add support for FieldRva to EnC delta #78033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dotnet/roslyn-compiler @cston @jjonescz ptal |
jjonescz
reviewed
Apr 10, 2025
src/Compilers/CSharp/Portable/Emitter/EditAndContinue/CSharpSymbolMatcher.cs
Show resolved
Hide resolved
src/Compilers/Core/Portable/Compilation/EmitDifferenceOptions.cs
Outdated
Show resolved
Hide resolved
DustinCampbell
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this'll need API review?
jjonescz
reviewed
Apr 14, 2025
037e0a2
to
dc5239d
Compare
fc50175
to
99aa804
Compare
jjonescz
approved these changes
May 2, 2025
src/Compilers/CSharp/Test/Emit2/Emit/EditAndContinue/EditAndContinueTests.cs
Outdated
Show resolved
Hide resolved
@cston PTAL |
cston
reviewed
May 8, 2025
cston
reviewed
May 8, 2025
cston
approved these changes
May 8, 2025
…tationDetails. Fix tests. Improve IL/field data validation in EnC tests
This was referenced May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Interactive
Feature - String Literals in Data Section as UTF8
Needs API Review
Needs to be reviewed by the API review council
untriaged
Issues and PRs which have not yet been triaged by a lead
VSCode
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on dotnet/runtime#112446, we append the field data to the IL stream and use existing RVA offset interpretation, except relative to the start of the IL stream.
Adds a new EnC capability
AddFieldRva
. If this capability is returned from the runtime the IDE instructs the compiler to use FieldRVA table to emit array initializers, stackalloc initializers, UTF8 strings and other features that rely on FieldRVA data in regular (non-EnC) emit.Allow Hot Reload to emit string literals when the limit on
#UserString
heap is reached.Moves emit of data section string literals down to ILBuilder, so that we can handle
Fixes #69480
Implements #78035
Depends on dotnet/runtime#112446