Skip to content

Conversation

AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs AlekseyTs requested review from 333fred and cston April 21, 2025 23:34
@AlekseyTs AlekseyTs requested review from a team as code owners April 21, 2025 23:34
@ghost ghost added the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 21, 2025
@AlekseyTs AlekseyTs requested a review from a team April 22, 2025 13:40
@AlekseyTs
Copy link
Contributor Author

@cston, @dotnet/roslyn-compiler For the second review

1 similar comment
@AlekseyTs
Copy link
Contributor Author

@cston, @dotnet/roslyn-compiler For the second review

@cston
Copy link
Contributor

cston commented Apr 23, 2025

            );

Should an error be reported for --x? #Resolved


Refers to: src/Compilers/CSharp/Test/Emit3/Symbols/UserDefinedCompoundAssignmentOperatorsTests.cs:5341 in 0ae0889. [](commit_id = 0ae0889, deletion_comment = False)

@cston
Copy link
Contributor

cston commented Apr 23, 2025

    }

Should we verify expected errors using the operators in C2, ..., C6, when called with operator syntax and with the explicit name? #Resolved


Refers to: src/Compilers/CSharp/Test/Emit3/Symbols/UserDefinedCompoundAssignmentOperatorsTests.cs:7476 in 0ae0889. [](commit_id = 0ae0889, deletion_comment = False)

@AlekseyTs
Copy link
Contributor Author

            );

Should an error be reported for --x?

There is an error on the declaration and, as we can observe below, the -- symbol doesn't have __arglist even when the syntax has it. BTW, the feature implementation didn't change the way __arglist is handled on parameters


In reply to: 2825074255


Refers to: src/Compilers/CSharp/Test/Emit3/Symbols/UserDefinedCompoundAssignmentOperatorsTests.cs:5341 in 0ae0889. [](commit_id = 0ae0889, deletion_comment = False)

@AlekseyTs
Copy link
Contributor Author

    }

Should we verify expected errors using the operators in C2, ..., C6, when called with operator syntax and with the explicit name?

I do not see any benefit in this for the purpose of this PR. Methods with MethodKind.Ordinary are not considered operators and there is nothing special about consuming them.


In reply to: 2825110362


Refers to: src/Compilers/CSharp/Test/Emit3/Symbols/UserDefinedCompoundAssignmentOperatorsTests.cs:7476 in 0ae0889. [](commit_id = 0ae0889, deletion_comment = False)

@AlekseyTs AlekseyTs merged commit 6c7bda1 into dotnet:features/UserDefinedCompoundAssignment Apr 23, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Feature-UserDefinedCompoundAssignmentOperators untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants