-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Address some PROTOTYPE comments #78241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address some PROTOTYPE comments #78241
Conversation
@cston, @dotnet/roslyn-compiler For the second review |
1 similar comment
@cston, @dotnet/roslyn-compiler For the second review |
Should we verify expected errors using the operators in Refers to: src/Compilers/CSharp/Test/Emit3/Symbols/UserDefinedCompoundAssignmentOperatorsTests.cs:7476 in 0ae0889. [](commit_id = 0ae0889, deletion_comment = False) |
There is an error on the declaration and, as we can observe below, the In reply to: 2825074255 Refers to: src/Compilers/CSharp/Test/Emit3/Symbols/UserDefinedCompoundAssignmentOperatorsTests.cs:5341 in 0ae0889. [](commit_id = 0ae0889, deletion_comment = False) |
I do not see any benefit in this for the purpose of this PR. Methods with In reply to: 2825110362 Refers to: src/Compilers/CSharp/Test/Emit3/Symbols/UserDefinedCompoundAssignmentOperatorsTests.cs:7476 in 0ae0889. [](commit_id = 0ae0889, deletion_comment = False) |
6c7bda1
into
dotnet:features/UserDefinedCompoundAssignment
No description provided.