Skip to content

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented May 2, 2025

No description provided.

@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels May 2, 2025
@dibarbet dibarbet force-pushed the debug_correctness branch 4 times, most recently from 738c305 to 824cfdf Compare May 2, 2025 19:08
@dibarbet dibarbet changed the title question mark Skip generate analyzer documentation to unblock ci May 2, 2025
@dibarbet dibarbet marked this pull request as ready for review May 2, 2025 19:09
@dibarbet dibarbet requested a review from a team as a code owner May 2, 2025 19:09
@dibarbet dibarbet force-pushed the debug_correctness branch from 824cfdf to 7e1d53a Compare May 2, 2025 19:24
@dibarbet dibarbet requested a review from a team as a code owner May 2, 2025 19:24
@dibarbet dibarbet force-pushed the debug_correctness branch from 7e1d53a to 7eb2a60 Compare May 2, 2025 19:37
@dibarbet dibarbet force-pushed the debug_correctness branch from 7eb2a60 to 5b2a693 Compare May 2, 2025 20:05
<!-- Only run validate only in CI builds. Running them in local builds will prevent refreshing auto-generated files. -->
<Exec Condition="'$(ContinuousIntegrationBuild)' == 'true'"
<Exec Condition="'$(ContinuousIntegrationBuild)' == 'true' and '$(SkipDocumentationValidation)' != 'true'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be setting _ValidateOffline instead? Since that will keep the other checks I think/hope.

(obviously that assumes the flag actually works...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will followup with other changes (e.g use offline mode, only run in correctness). I don't want to keep CI blocked while I try and iterate on other flags.

@dibarbet dibarbet merged commit f57fbdc into dotnet:main May 2, 2025
16 of 28 checks passed
@dibarbet dibarbet deleted the debug_correctness branch May 2, 2025 21:06
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 2, 2025
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants