Skip to content

Conversation

AlekseyTs
Copy link
Contributor

@AlekseyTs AlekseyTs commented May 15, 2025

Relates to test plan #76130

@AlekseyTs AlekseyTs requested review from jjonescz and jcouv May 15, 2025 14:58
@AlekseyTs AlekseyTs requested a review from a team as a code owner May 15, 2025 14:58
@AlekseyTs AlekseyTs added Area-Compilers Feature - Extension Everything The extension everything feature labels May 15, 2025
@AlekseyTs
Copy link
Contributor Author

@jcouv, @jjonescz, @dotnet/roslyn-compiler Please review.

@jcouv jcouv self-assigned this May 15, 2025
@@ -237,42 +238,45 @@ bool isApplicableToReceiver(UnaryOperatorSignature candidate, BoundExpression op
}
}

private class PairedExtensionUnaryOperatorSignatureComparer : IEqualityComparer<UnaryOperatorSignature>
private class PairedExtensionOperatorSignatureComparer : IEqualityComparer<MethodSymbol>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving this to a separate file since it's not used only by unary operators now.

@AlekseyTs
Copy link
Contributor Author

@jcouv, @dotnet/roslyn-compiler For the second review.

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (commit 2)

@AlekseyTs AlekseyTs merged commit 0b0a222 into dotnet:features/extensions May 17, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Feature - Extension Everything The extension everything feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants