Ensure we pass unique binlog paths to each BuildHost #78599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
reviewed
May 15, 2025
RikkiGibson
approved these changes
May 15, 2025
jasonmalinowski
force-pushed
the
fix-binlog-locking
branch
from
4602df5 to
6beec60
Compare
dibarbet
approved these changes
May 15, 2025
|
@jasonmalinowski I am going to try to pull down your branch and start passing a binlog path, as I am concerned the lack of it is causing some diagnostics to be dropped. |
|
Did you manually test the change? I am still seeing a "cannot access because it is being used by another process" error. |
|
@jasonmalinowski I disabled auto merge just to first make sure the PR is doing what we expect. |
Actually no -- we know this could have been a cause but if there's more then that's interesting. |
|
I think this makes the situation better, but I have to keep investigating to get to the root of the issue. Feel free to merge when ready. |
Otherwise if we launch multiple processes, they might step atop each other and cause locking issues.
Somehow almost every line started with a UTF-8 BOM. This fixes it.
jasonmalinowski
force-pushed
the
fix-binlog-locking
branch
from
6beec60 to
12369bc
Compare
This was referenced May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise if we launch multiple processes, they might step atop each other and cause locking issues.