Initial support for conditional logical binary extension operators #78706
Conversation
AlekseyTs
added
the
Feature - Extension Everything
|
@jcouv, @dotnet/roslyn-compiler Please review |
|
|
||
| [Theory] | ||
| [CombinatorialData] | ||
| public void Binary_045_Consumption_Logical_InDifferentBlocks([CombinatorialValues("&&", "||")] string op) |
There was a problem hiding this comment.
nit: Consider testing from metadata too #Closed
|
|
||
| [Theory] | ||
| [CombinatorialData] | ||
| public void Binary_053_Consumption_Logical_TrueOrFalseInDifferentClass([CombinatorialValues("&&", "||")] string op) |
There was a problem hiding this comment.
Do we have a test like this but the true/false operators are together (separate from the logical operator)? #Closed
There was a problem hiding this comment.
I do not find this scenario particularly interesting. Adding Binary_055_Consumption_Logical_TrueOrFalseInDifferentClass for completeness.
| static void Main() | ||
| { | ||
| var s1 = (1, 2); | ||
| s1 = s1 {{{op}}} s1; |
There was a problem hiding this comment.
Consider verifying the info from semantic model in scenario with "generic operator" #Closed
|
The title of the PR seems off. The logical operators are |
| """; | ||
|
|
||
| var comp = CreateCompilation(src1, options: TestOptions.DebugExe); | ||
| comp.VerifyDiagnostics( |
There was a problem hiding this comment.
VerifyEmitDiagnostics? (here and elsewhere as well) #Closed
AlekseyTs
changed the title
|
@dotnet/roslyn-compiler For the second review. |
|
@dotnet/roslyn-compiler For another review |
|
@dotnet/roslyn-compiler For another review |
|
@dotnet/roslyn-compiler For another review |
Relates to test plan #76130