Skip to content

Ensure sln load uses project absolute paths #78772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

Ensure sln load uses project absolute paths #78772

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c38ed43
Ensure sln load uses project absolute paths
dibarbet May 30, 2025
15406f5
Adjust implementation to respect diagnostic flag and update tests
dibarbet May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Workspaces/MSBuild/Core/MSBuild/SolutionFileReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,17 @@ internal partial class SolutionFileReader
var builder = ImmutableArray.CreateBuilder<(string ProjectPath, string ProjectGuid)>();
foreach (var projectModel in solutionModel.SolutionProjects)
{
Contract.ThrowIfFalse(pathResolver.TryGetAbsoluteProjectPath(projectModel.FilePath, baseDirectory, DiagnosticReportingMode.Throw, out var absoluteProjectPath));
// If we are filtering based on a solution filter, then we need to verify the project is included.
if (!projectFilter.IsEmpty)
{
Contract.ThrowIfFalse(pathResolver.TryGetAbsoluteProjectPath(projectModel.FilePath, baseDirectory, DiagnosticReportingMode.Throw, out var absoluteProjectPath));
if (!projectFilter.Contains(absoluteProjectPath))
{
continue;
}
}

builder.Add((projectModel.FilePath, projectModel.Id.ToString()));
builder.Add((absoluteProjectPath, projectModel.Id.ToString()));
}

return builder.ToImmutable();
Expand Down
Loading