Skip to content

Switch return to continue #78781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
Merged

Switch return to continue #78781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .../Core/Portable/Workspace/ProjectSystem/ProjectSystemProject.BatchingDocumentCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,15 +478,16 @@ private async ValueTask ProcessDynamicFileChangesAsync(ImmutableSegmentedList<(s

using (await _project._gate.DisposableWaitAsync(cancellationToken).ConfigureAwait(false))
{
// If our project has already been removed, this is a stale notification, and we can disregard.
// If our project has already been removed, and we can disregard everything and just 'return'
if (_project.HasBeenRemoved)
return;

// For everything else, if it's not here 'continue' to the next item in the batch.
if (!_documentPathsToDocumentIds.TryGetValue(workspaceFilePath, out documentId))
return;
continue;

if (!_documentIdToDynamicFileInfoProvider.TryGetValue(documentId, out fileInfoProvider))
return;
continue;
}

// Now that we've got all our basic data, let's fetch the new document outside the lock, since this could be expensive.
Expand Down
Loading